(maint) modulesync 892c4cf #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HAIL9000 looks like this needs some tweaks, shout if you want me to look at it. as part of triage |
spec/spec_helper.rb
Outdated
| if Puppet::Util::Package.versioncmp(Puppet.version, '4.5.0') >= 0 | ||
| RSpec.configure do |c| | ||
| c.before :each do | ||
| Puppet.settings[:strict] = :error |
There was a problem hiding this comment.
Apt throws deprecation warnings and this means they are thrown as errors during testing, the current reason Travis run is failing.
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
(maint) modulesync 892c4cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is merged, it’d be much appreciated if the merger could remove the
msync_18sep17_892c4cfbranch from thepuppetlabsfork.Thank you! 💖